-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: github.com/moby/sys/mountinfo v0.2.0 #2591
Conversation
@@ -22,5 +22,5 @@ require ( | |||
// NOTE: urfave/cli must be <= v1.22.1 due to a regression: https://github.com/urfave/cli/issues/1092 | |||
github.com/urfave/cli v1.22.1 | |||
github.com/vishvananda/netlink v1.1.0 | |||
golang.org/x/sys v0.0.0-20200728102440-3e129f6d46b1 | |||
golang.org/x/sys v0.0.0-20200909081042-eff7692f9009 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that the golang.org/x/sys updates are incompatible with the containerd/console package, and break compile on macOS. A fix is open for this in containerd/console#40
I don't think anything in runc is compiled on macOS currently, so probably not a blocker, but it may cause issues for projects that use runc as a go module, as it will force them to update to a newer golang.org/x/sys version
@kolyshkin @cyphar ptal |
full diff: moby/sys@mountinfo/v0.1.3...mountinfo/v0.2.0 Bug fixes: - Fix path unescaping for paths with double quotes Improvements: - Mounted: speed up by adding fast paths using openat2 (Linux-only) and stat - Mounted: relax path requirements (allow relative, non-cleaned paths, symlinks) - Unescape fstype and source fields - Documentation improvements Testing/CI: - Unit tests: exclude darwin - CI: run tests under Fedora 32 to test openat2 - TestGetMounts: fix for Ubuntu build system - Makefile: fix ignoring test failures - CI: add cross build Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
f5c35b4
to
71c10e3
Compare
@AkihiroSuda I pushed again, so looks like you need to re-approve 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and 👍 for openat2 support. 😸
full diff: moby/sys@mountinfo/v0.1.3...mountinfo/v0.2.0
Bug fixes:
Improvements:
Testing/CI: